Re: [PATCH] pgindent truncates last line of files missing a trailing newline - Mailing list pgsql-hackers

Akshay Joshi <akshay.joshi@enterprisedb.com> writes:

I have addressed the review comments from Andrew.
Attached is the v2 patch, ready for review.

I'm not sure I want to expend the brain cells to figure out whether
this is a correct/complete patch.  If pg_bsd_indent were less of an
undercommented spaghetti-code nightmare, maybe fixing it here would
be reasonable.  But as things stand, why don't we just fix this in
the perl wrapper, as attached?

Well, I thought we were trying to reduce the fixups we did in pgindent. However, I take your point about the ugly nature of the pg_bsd_indent code. So I'm ok with this fix, which is quite straightforward.

(In any case, I'm not in favor of adding a test case, because that
would require putting a trailing-newline-less .c file into our tree.
At best there would be a permanent hazard of something "fixing"
the file.)
			

fair point.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com