Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Date
Msg-id 13522.1404059410@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.  (Kevin Grittner <kgrittn@ymail.com>)
Responses Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.  (Kevin Grittner <kgrittn@ymail.com>)
List pgsql-hackers
Kevin Grittner <kgrittn@ymail.com> writes:
> Gurjeet Singh <gurjeet@singh.im> wrote:
>> Besides, there's already a throttle built in using the
>> PGSTAT_STAT_INTERVAL limit.

> This is a key point; neither the original patch nor my proposed
> alternative bypasses that throttling.

That's a fair point that probably obviates my objection.  I think the
interval throttling is more recent than the code in question.

If we're going to do it like this, then I think the force flag should
be considered to do nothing except override the clock check, which
probably means it shouldn't be tested in the initial if() at all.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: PostgreSQL for VAX on NetBSD/OpenBSD
Next
From: Kevin Grittner
Date:
Subject: Re: idle_in_transaction_timeout