Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section
Date
Msg-id 134675be-cf09-7f8c-9eba-e87fb13990d5@sigaev.ru
Whole thread Raw
In response to FinishPreparedTransaction missing HOLD_INTERRUPTS section  (Stas Kelvich <s.kelvich@postgrespro.ru>)
List pgsql-hackers
Thank you, pushed!

Stas Kelvich wrote:
> Hello.
> 
> It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't
> hold interrupts around writing to wal and cleaning up ProcArray and GXact
> entries. At least RemoveTwoPhaseFile (which is called in between) can print
> a warning with ereport(), which, in turn will check for interrupts and
> therefore can cancel backend or throw an error before GXact clean-up.
> 
> Other similar places like CommitTransaction and PrepareTransaction have
> such hold interrupts sections.
> 
> --
> Stas Kelvich
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


pgsql-hackers by date:

Previous
From: Stas Kelvich
Date:
Subject: Re: Global snapshots
Next
From: Peter Eisentraut
Date:
Subject: Re: Python 3.7 support