Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] lock_timeout and common SIGALRM framework - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] lock_timeout and common SIGALRM framework
Date
Msg-id 1341351329-sup-8565@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] lock_timeout and common SIGALRM framework  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: [PATCH] lock_timeout and common SIGALRM framework
List pgsql-hackers
Tree view 

I don't understand why PGSemaphoreTimedLock() is not broken.  I mean
surely you need a bool return to let the caller know whether the
acquisition succeeded or failed?  AFAICS you are relying on
get_timeout_indicator() but this seems to me the wrong thing to do ...
(not to mention how ugly it is to percolate through two levels of
abstraction)

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] lock_timeout and common SIGALRM framework
Next
From: Alexander Korotkov
Date:
Subject: Re: Patch: add conversion from pg_wchar to multibyte