Re: RelationGetIndexAttrBitmap comment outdated - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: RelationGetIndexAttrBitmap comment outdated
Date
Msg-id 133EC44B-573A-443C-8900-E968AA81EB6B@yesql.se
Whole thread Raw
In response to RelationGetIndexAttrBitmap comment outdated  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
> On 12 Jul 2023, at 16:37, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> I realized that commit 19d8e2308bc5 (and 5753d4ee320b before that) added
> a new output type to RelationGetIndexAttrBitmap but forgot to list its
> effect in the function's documenting comment.  Here's a patch that
> updates it, making it more specific (and IMO more readable).  I also add
> a comment to the enum definition, to remind people that the other one
> needs to be modified.

LGTM, a clear improvement.

> This ought to be backpatched to 16.

+1

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: RelationGetIndexAttrBitmap comment outdated
Next
From: Önder Kalacı
Date:
Subject: Re: [Patch] Use *other* indexes on the subscriber when REPLICA IDENTITY is FULL