plperl_helpers.h fix for clang - Mailing list pgsql-hackers

From Peter Eisentraut
Subject plperl_helpers.h fix for clang
Date
Msg-id 1337879961.17469.5.camel@vanquo.pezone.net
Whole thread Raw
Responses Re: plperl_helpers.h fix for clang
List pgsql-hackers
clang warns about that newish SvREFCNT_inc(sv) call in plperl_helpers.h
about an unused return value, because the macro expansion of
SvREFCNT_inc(sv) returns sv.  The merit of that warning might be
debatable, but it seems easy to fix by using SvREFCNT_inc_void(sv)
instead.

And we could use SvREFCNT_inc_simple_void(sv), since sv doesn't have any
side effects, but that's optional.

Any concerns?




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [RFC] Interface of Row Level Security
Next
From: Robert Haas
Date:
Subject: Re: [RFC] Interface of Row Level Security