Excerpts from Joachim Wieland's message of mié abr 04 15:43:53 -0300 2012:
> On Wed, Apr 4, 2012 at 8:27 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
> >> Sure, PrintStatus is just there for now to see what's going on. My
> >> plan was to remove it entirely in the final patch.
> >
> > We need that final patch NOW, I think. There is very little time for this
> > before it will be too late for 9.2.
>
> Here are updated patches:
>
> - An empty directory for the directory archive format is okay now.
> - Removed PrintStatus().
In general I'm not so sure that removing debugging printouts is the best
thing to do. They might be helpful if in the future we continue to
rework this code. How about a #define that turns them into empty
statements instead, for example? I didn't read carefully to see if the
PrintStatus() calls are reasonable to keep, though.
--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
