On ons, 2012-03-21 at 11:57 -0300, Alvaro Herrera wrote:
> Excerpts from Robert Haas's message of mié mar 21 11:43:17 -0300 2012:
> > On Fri, Mar 16, 2012 at 1:34 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > > Here is a patch for being able to rename constraints of domains. It
> > > goes on top of the previously committed patch for renaming table
> > > constraints.
> >
> > I don't like the way you've modified get_constraint_oid(), which is
> > currently parallel to many other get_whatever_oid() functions and with
> > this patch, would no longer be. There seems to be little point in
> > shoehorning the new functionality into the existing function anyway,
> > considering that you've conditionalized basically every piece of logic
> > in the function. I think you should just invent a completely separate
> > function and be done with it.
>
> get_relation_constraint_oid() plus get_domain_constraint_oid()?
Makes sense. Updated patch attached.
