Re: Consistent timestamp input - Mailing list pgsql-patches

From Tom Lane
Subject Re: Consistent timestamp input
Date
Msg-id 13297.1056402308@sss.pgh.pa.us
Whole thread Raw
In response to Consistent timestamp input  ("Greg Sabino Mullane" <greg@turnstep.com>)
Responses Re: Consistent timestamp input  (greg@turnstep.com)
List pgsql-patches
"Greg Sabino Mullane" <greg@turnstep.com> writes:
> This one bugged me so much, I made a patch for it. It enforces
> consistent interpretation of date input:

This cannot be right can it?  The code used to check EuroDates and now
it doesn't.  ISTM you must have broken either Euro or US format.

Also, I thought that the consensus on -general was that the heuristics
involving looking at the range of the values were a bad idea.  (While
I disagree, I can recognize a lost cause when I see one.)  You've still
got them in there.  ISTM the code ought to assume MM before DD if ISO
or Euro style, otherwise (US style) assume DD before MM, and then reject
if out of range, rather than allowing the range to determine which is
which.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Greg Sabino Mullane"
Date:
Subject: Consistent timestamp input
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] ss_family in hba.c