Postgres Pro
Downloads
Home   >   mailing lists

Re: hiding variable-length fields from Form_pg_* structs - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: hiding variable-length fields from Form_pg_* structs
Date
Msg-id 1327600881.26839.3.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: hiding variable-length fields from Form_pg_* structs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: hiding variable-length fields from Form_pg_* structs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On mån, 2012-01-09 at 14:04 -0500, Tom Lane wrote:
> #ifdef CATALOG_VARLEN           /* variable-length fields start here
> */
>
> to be even clearer.
>
> What would be appropriate to add instead of those inconsistently-used
> comments is explicit comments about the exception cases such as
> proargtypes, to make it clear that the placement of the #ifdef
> CATALOG_VARLEN is intentional and not a bug in those cases.
>
I implemented your suggestions in the attached patch.
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Configuring Postgres to Add A New Source File
Next
From: Vik Reykja
Date:
Subject: Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin"