Re: [PATCH] Log crashed backend's query (activity string) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Log crashed backend's query (activity string)
Date
Msg-id 1315430492-sup-8827@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] Log crashed backend's query (activity string)  (Marti Raudsepp <marti@juffo.org>)
Responses Re: [PATCH] Log crashed backend's query (activity string)
List pgsql-hackers
Excerpts from Marti Raudsepp's message of mié sep 07 18:09:32 -0300 2011:
> On Wed, Sep 7, 2011 at 22:42, Alvaro Herrera <alvherre@commandprompt.com> wrote:
> > A mishandled encoding conversion could be problematic, so that needs to
> > be carefully considered (perhaps just shut off unconditionally).
> 
> Are you referring to log file encoding or something else? The log file
> is already potentially mixed-encoding, as different databases may have
> different encodings and backends just dump bytes to it in their
> current encoding.

I am referring to the fact that whatever the backend puts in shared
memory is going to be in its encoding setting, which may not necessarily
match the postmaster's.  And if it doesn't, the postmaster might try to
convert it using settings not valid for the string, possibly leading to
crashes.

I remember we had bugs whereby an encoding conversion would fail,
leading to elog trying to report this problem, but this attempt would
also incur a conversion step, failing recursively until elog's stack got
full.  I'm not saying this is impossible to solve, just something to
keep in mind.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Log crashed backend's query (activity string)
Next
From: Robert Haas
Date:
Subject: Re: FATAL: lock AccessShareLock on object 0/1260/0 is already held