Re: Partitioned tables and covering indexes - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: Partitioned tables and covering indexes
Date
Msg-id 13123421-1d52-d0e4-c95c-6d69011e0595@sigaev.ru
Whole thread Raw
In response to Re: Partitioned tables and covering indexes  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: Partitioned tables and covering indexes
List pgsql-hackers
> Actually, discovered bug is not related to patch except new test faces 
> with it,
> problem is: CompareIndexInfo() checks rd_opfamily for equality for all 
> attributes, not only for key attribute.

Patch attached. But it seems to me, field's names of
IndexInfo structure are a bit confused now:
     int         ii_NumIndexAttrs;   /* total number of columns in index */
     int         ii_NumIndexKeyAttrs;    /* number of key columns in 
index */
     AttrNumber  ii_KeyAttrNumbers[INDEX_MAX_KEYS];


ii_KeyAttrNumbers contains all columns, i.e. it contains 
ii_NumIndexAttrs number of columns, not a ii_NumIndexKeyAttrs number as 
easy to think.

I suggest rename ii_KeyAttrNumbers to ii_AttrNumbers or 
ii_IndexAttrNumbers. Opinions?


>      for (i = 0; i < info1->ii_NumIndexAttrs; i++)
>      {
>          if (maplen < info2->ii_KeyAttrNumbers[i])
> 


-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/

Attachment

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: lazy detoasting
Next
From: Alvaro Herrera
Date:
Subject: Re: Partitioned tables and covering indexes