Re: reducing the overhead of frequent table locks, v4 - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: reducing the overhead of frequent table locks, v4
Date
Msg-id 1310337885.3012.258.camel@jdavis
Whole thread Raw
In response to reducing the overhead of frequent table locks, v4  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
A few very minor things that I noticed:

1. You use pre-increment in "for" loops (e.g. FastPathGrantLock). The
rest of the code seems to use post-increment in "for" loops, so you
might as well stick to the convention in cases where the two have
identical meaning.

2. Typo in the README: "acquire the every" should be "acquire every".

3. Typo in comment in lock.c: "last because most" should be "last
because it's the most". (I just realized that's actually not your typo,
so fixing it is optional).

Regards,Jeff Davis



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)
Next
From: Robert Haas
Date:
Subject: Re: reducing the overhead of frequent table locks, v4