Re: avoid including rel.h in execnodes.h - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: avoid including rel.h in execnodes.h
Date
Msg-id 1309807428-sup-7621@alvh.no-ip.org
Whole thread Raw
In response to Re: avoid including rel.h in execnodes.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Excerpts from Tom Lane's message of vie jul 01 18:20:50 -0400 2011:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

> > I also included rel.h in spi.h, because it was previously indirectly
> > included via execnodes.h and with this patch it would no longer be,
> > which is a problem because it'd cause external code to fail to compile.
> 
> If we think that not including rel.h unnecessarily is a good thing, then
> that should surely apply to external code as well.  So -1 for that bit.
> It's not like we have not removed stuff from spi.h before.

Thanks, committed with that change.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [BUGS] BUG #6083: psql script line numbers incorrectly count \copy data
Next
From: Michael Glaesemann
Date:
Subject: Re: non-superuser reserved connections? connection pools?