Re: 9.0beta2 - server crash when using HS + SR - Mailing list pgsql-hackers

From Tom Lane
Subject Re: 9.0beta2 - server crash when using HS + SR
Date
Msg-id 13097.1277918847@sss.pgh.pa.us
Whole thread Raw
In response to Re: 9.0beta2 - server crash when using HS + SR  (Bruce Momjian <bruce@momjian.us>)
Responses Re: 9.0beta2 - server crash when using HS + SR  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> The attached patch shows the hint only during recovery.

BTW, it would be easier and more consistent with the rest of the code to
look at InRecovery, instead of messing around with the function
signature.  And the usual way to emit a hint conditionally is
(InRecovery ? errhint(...) : 0)

rather than duplicate a lot of surrounding code.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 9.0beta2 - server crash when using HS + SR
Next
From: Magnus Hagander
Date:
Subject: Re: Check constraints on non-immutable keys