Re: PATCH: CreateComments: use explicit indexing for ``values'' - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: PATCH: CreateComments: use explicit indexing for ``values''
Date
Msg-id 1308061154-sup-6995@alvh.no-ip.org
Whole thread Raw
In response to Re: PATCH: CreateComments: use explicit indexing for ``values''  (richhguard-monotone@yahoo.co.uk)
Responses Re: PATCH: CreateComments: use explicit indexing for ``values''
List pgsql-hackers
Excerpts from richhguard-monotone's message of lun jun 13 16:10:17 -0400 2011:
> Apologies - I meant to CC in the list but forgot.
> 
> I have gone through and changed all the related functions except ``update_attstats''.
> 
> Do you have any advice of how to handle the inner loops, such as those initializing ``stakindN''. The entries before
canbe handled just like in this patch, by using the symbolic constants.
 

Based on Tom's comments, I'd submit the patch without that bit, at least
as a first step.

> Again, this is based on master and all existing tests pass.

Please post the patch and add it here:
https://commitfest.postgresql.org/action/commitfest_view?id=10

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: Boolean operators without commutators vs. ALL/ANY
Next
From: Alexander Korotkov
Date:
Subject: Re: WIP: collect frequency statistics for arrays