Re: creating CHECK constraints as NOT VALID - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: creating CHECK constraints as NOT VALID
Date
Msg-id 1307033061-sup-51@alvh.no-ip.org
Whole thread Raw
In response to Re: creating CHECK constraints as NOT VALID  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: creating CHECK constraints as NOT VALID
Re: creating CHECK constraints as NOT VALID
List pgsql-hackers
Excerpts from Alvaro Herrera's message of mié jun 01 20:56:12 -0400 2011:
> Excerpts from Thom Brown's message of mié jun 01 19:48:44 -0400 2011:
>
> > Is this expected?
> > [ pg_dump fails to preserve not-valid status of constraints ]
>
> Certainly not.
>
> > Shouldn't the constraint be dumped as not valid too??
>
> Sure, I'll implement that tomorrow.

Actually, it turns out that NOT VALID foreign keys were already buggy
here, and fixing them automatically fixes this case as well, because the
fix involves touching pg_get_constraintdef to dump the flag.  This also
gets it into psql's \d.  Patch attached.

(Maybe the changes in psql's describe.c should be reverted, not sure.)

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Please test peer (socket ident) auth on *BSD
Next
From: Marko Kreen
Date:
Subject: Re: Please test peer (socket ident) auth on *BSD