Re: Recommend wrappers of PG_DETOAST_DATUM_PACKED() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Recommend wrappers of PG_DETOAST_DATUM_PACKED()
Date
Msg-id 13059.1477407793@sss.pgh.pa.us
Whole thread Raw
In response to Recommend wrappers of PG_DETOAST_DATUM_PACKED()  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced single-byte
> varlena headers, its fmgr.h changes presented PG_GETARG_TEXT_PP() and
> PG_GETARG_TEXT_P() as equals.  Its postgres.h changes presented
> PG_DETOAST_DATUM_PACKED() and VARDATA_ANY() as the exceptional case.  Let's
> firmly recommend PG_GETARG_TEXT_PP() over PG_GETARG_TEXT_P(); likewise for
> other ...PP() macros.  This shaves cycles and brings consistency of style.

+1
        regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Recommend wrappers of PG_DETOAST_DATUM_PACKED()
Next
From: Bruce Momjian
Date:
Subject: Wraparound warning