Re: generic reloptions improvement - Mailing list pgsql-hackers

From Tom Lane
Subject Re: generic reloptions improvement
Date
Msg-id 1301.1231112228@sss.pgh.pa.us
Whole thread Raw
In response to Re: generic reloptions improvement  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> This is the patch in its final form.  I have included a few macros to
> simplify the writing of amoptions routines.

Minor gripes:

* Does initialize_reloptions() need to be exported?  It seems to be
only called within parseRelOptions().  It's far from clear who else
should be expected to call it.

* The HANDLE_ macros are dangerous as-is (dangling if/else).  Need to
use the usual do/while trick.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Alex Hunsaker"
Date:
Subject: [PATCH] ALTER TABLE SET (compress_max_size... = )
Next
From: "Hitoshi Harada"
Date:
Subject: Re: WIP patch for basic window frame support