> + defstring = defGetString(defel);
> + if (pg_strcasecmp(defstring, "True") == 0)
> + d->acceptAll = true;
> + else if (pg_strcasecmp(defstring, "False") == 0)
> + d->acceptAll = false;
> + else
> + ereport(ERROR,
> + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> + errmsg("invalid value for AcceptAll parameter: \"%s\"",
> + defstring)));
This bit should be replaced with defGetBoolean. Otherwise it looks
reasonably sane.
regards, tom lane