Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords - Mailing list pgsql-patches

From Tom Lane
Subject Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords
Date
Msg-id 13005.1195012241@sss.pgh.pa.us
Whole thread Raw
In response to a tsearch2 (8.2.4) dictionary that only filters out stopwords  (Jan Urbański <j.urbanski@students.mimuw.edu.pl>)
Responses Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords
List pgsql-patches
> +            defstring = defGetString(defel);
> +            if (pg_strcasecmp(defstring, "True") == 0)
> +                d->acceptAll = true;
> +            else if (pg_strcasecmp(defstring, "False") == 0)
> +                d->acceptAll = false;
> +            else
> +                ereport(ERROR,
> +                    (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> +                     errmsg("invalid value for AcceptAll parameter: \"%s\"",
> +                             defstring)));

This bit should be replaced with defGetBoolean.  Otherwise it looks
reasonably sane.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Contrib docs v1
Next
From: Greg Sabino Mullane
Date:
Subject: Better default_statistics_target