Re: pl/python refactoring - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pl/python refactoring
Date
Msg-id 1295555913.27153.2.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: pl/python refactoring  (Hitoshi Harada <umi.tanuki@gmail.com>)
List pgsql-hackers
On ons, 2011-01-19 at 10:06 +0900, Hitoshi Harada wrote:
> - This is not in the patch, but around line 184 "vis versa" in comment
> seems like typo.

Fixed.

> - A line break should be added before PLy_add_exception() after "static void"

I'll add that when I get to the patch.

> - This is also not in the patch, but the comment
> /* these should only be called once at the first call
>  * of plpython_call_handler.  initialize the python interpreter
>  * and global data.
>  */
> is bogus. PLy_init_interp() is called in _PG_init().

Fixed.




pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: SSI patch version 13
Next
From: Tom Lane
Date:
Subject: Re: REVIEW: EXPLAIN and nfiltered