Re: Extensions, this time with a patch - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Extensions, this time with a patch
Date
Msg-id 1290464046-sup-6478@alvh.no-ip.org
Whole thread Raw
In response to Re: Extensions, this time with a patch  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
Responses Re: Extensions, this time with a patch
List pgsql-hackers
Excerpts from Dimitri Fontaine's message of lun nov 22 18:12:39 -0300 2010:
> Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
> > No. My suggestion was just to use the internal parser.
> 
> What about something like the attached, cfparser.v3.patch?

the handling of relative vs absolute paths is bogus here.  I think it'd
make more sense to have a bool "are we including"; and if that's false and
the path is not absolute, then the file is relative to CWD; or maybe we
make it absolute by prepending PGDATA; maybe something else?  (need to
think of something that makes sense for both recovery.conf and extension
control files)


> If that looks ok, do we want to add some documentation about the new
> lexer capabilities?

beyond extra code comments?  probably not.

> Also, for what good reason would we want to prevent
> people from using the include facility?

Not sure about this

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Extensions, this time with a patch
Next
From: Alvaro Herrera
Date:
Subject: reporting reason for certain locks