Re: APC/socket fix (final?) - Mailing list pgsql-patches

Claudio Natoli <claudio.natoli@memetrics.com> writes:
> + #ifdef WIN32
> +     /* Interrupted by socket/APC interaction? */
> +     if (n < 0 && GetLastError() == ERROR_IO_PENDING)
> +         errno = EINTR;
> + #endif

This seems a bit schizophrenic; if you can assign to errno, why can't you
read from it?  Would look more consistent if the code looked like

    if (n < 0 && errno == ERROR_IO_PENDING)
        errno = EINTR;

            regards, tom lane