Re: pg_basebackup failed to back up large file - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_basebackup failed to back up large file
Date
Msg-id 12852.1401806455@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_basebackup failed to back up large file  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: pg_basebackup failed to back up large file  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-06-03 23:19:37 +0900, Fujii Masao wrote:
>> -            if (sscanf(copybuf + 124, "%11o", ¤t_len_left) != 1)
>> +            if (sscanf(copybuf + 124, "%11lo", ¤t_len_left) != 1)

> That's probably not going to work on 32bit platforms or windows where
> you might need to use ll instead of l as a prefix. Also notice that
> apparently (c.f. 9d7ded0f4277f5c0063eca8e871a34e2355a8371) sscanf can't
> reliably be used for 64bit input :(. That pretty much sucks...

There's a far bigger problem there, which is if we're afraid that
current_len_left might exceed 4GB then what is it exactly that guarantees
it'll fit in an 11-digit field?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUGS] BUG #9652: inet types don't support min/max
Next
From: Andres Freund
Date:
Subject: strtoll/strtoull emulation