Re: Refactor pg_dump as a library? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Refactor pg_dump as a library?
Date
Msg-id 1283.1460655216@sss.pgh.pa.us
Whole thread Raw
In response to Re: Refactor pg_dump as a library?  (David Steele <david@pgmasters.net>)
Responses Re: Refactor pg_dump as a library?
List pgsql-hackers
David Steele <david@pgmasters.net> writes:
> On 4/14/16 7:16 AM, Andreas Karlsson wrote:
>> I am personally not a fan of the pg_get_Xdef() functions due to their
>> heavy reliance on the syscache which feels rather unsafe in combination
>> with concurrent DDL.

> As far as I know pg_dump share locks everything before it starts so
> there shouldn't be issues with concurrent DDL.  Try creating a new
> inherited table with FKs, etc. during a pg_dump and you'll see lots of
> fun lock waits.

I think pg_dump is reasonably proof against DDL on tables.  It is not
at all proof against DDL on other sorts of objects, such as functions,
because of the fact that the syscache will follow catalog updates that
occur after pg_dump's transaction snapshot.
        regards, tom lane



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Refactor pg_dump as a library?
Next
From: David Steele
Date:
Subject: Re: Refactor pg_dump as a library?