Re: missing "else" in postmaster.c? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: missing "else" in postmaster.c?
Date
Msg-id 1277227207-sup-5889@alvh.no-ip.org
Whole thread Raw
In response to missing "else" in postmaster.c?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Excerpts from Robert Haas's message of lun jun 21 22:18:46 -0400 2010:
> In pmdie(), we have the following code, which doesn't seem to make
> much sense.  If the state is PM_RECOVERY at the top of this section it
> will get changed to PM_WAIT_BACKENDS and then to PM_WAIT_BACKENDS
> again.  Either the two "if" statements should be merged (and both bits
> should be handled with the same block of code) or the second one
> should say "else if".  Or at least, I think so...

I'd just move the first block below the second one.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Mike Fowler
Date:
Subject: Re: Adding XMLEXISTS to the grammar
Next
From: Florian Pflug
Date:
Subject: Re: TCP keepalive support for libpq