Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization
Date
Msg-id 12696.1510592632@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] pgbench: Skipping the creating primary keys afterinitialization  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Tree view 
Masahiko Sawada <sawada.mshk@gmail.com> writes:
> [ pgbench_custom_initialization_v16.patch ]

I'm starting to review this patch, and I wonder how it is that you
ended up with "c" as the command letter for dropping existing tables.
Seems like "d" for DROP would be much less confusing.  I see that at
one point "d" meant the data load step, but since you've gone with
"g" for "generate data" that conflict is gone.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Migration to PGLister - After
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table