Re: cleanup error reporting - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: cleanup error reporting
Date
Msg-id 1255.24.211.165.134.1141219397.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: cleanup error reporting  (Neil Conway <neilc@samurai.com>)
Responses Re: cleanup error reporting  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Neil Conway said:
> On Tue, 2006-02-28 at 22:38 -0500, Tom Lane wrote:
>> There are one or two "cannot"s that should be "could not"s in your hit
>> list, per the style guidelines.
>>
>> While you're at it -- I noticed several of the tsearch2 messages refer
>> to "lexem(s)".  The word is "lexeme", the plural "lexemes", so this
>> should be "lexeme(s)".  Looks like it's misspelled various places in
>> the README and code comments too ...
>
> Thanks for the suggestions -- I fixed both of those issues, and applied
> a revised patch to HEAD.
>

This has apparently broken regression tests in both contrib and PL. See
buildfarm for details.

(side note - maybe we need a check target for these that uses a temp install
- that would make it easier to check for errors like this).

cheers

andrew



pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: cleanup StringInfo usage
Next
From: Tom Lane
Date:
Subject: Re: cleanup error reporting