Re: Logging configuration changes [REVIEW] - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Logging configuration changes [REVIEW]
Date
Msg-id 1253223568.21712.16.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: Logging configuration changes [REVIEW]  (Abhijit Menon-Sen <ams@toroid.org>)
List pgsql-hackers
On ons, 2009-09-16 at 10:54 +0530, Abhijit Menon-Sen wrote:
> I can't help but think that it would be nice to report the default value
> of a parameter that is reset (i.e. "parameter $x reset to default value
> $y"). The first attached patch does this by calling GetConfigOption()
> after the value has been reset by set_config_option(). It also skips
> the report if the earlier value was the same as the default.

I have applied the rest, but the problem with this change is that it
logs the values without units.  I'm not sure that we want to expose
that.




pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Fwd: Copy out wording
Next
From: Tom Lane
Date:
Subject: Re: Feedback on getting rid of VACUUM FULL