pg_ctl infinite loop and memory leak - Mailing list pgsql-bugs

From Jeff Davis
Subject pg_ctl infinite loop and memory leak
Date
Msg-id 1251838342.31412.144.camel@monkey-cat.sm.truviso.com
Whole thread Raw
Responses Re: pg_ctl infinite loop and memory leak  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pg_ctl infinite loop and memory leak  (Bruce Momjian <bruce@momjian.us>)
List pgsql-bugs
To reproduce:

1. initdb -D data
2. cat /dev/null > data/postgresql.conf
3. pg_ctl -w -D data start

I attached a quick patch that seems to do the trick. It appears that
fgets() will always return non-NULL if the size passed in is 1 (i.e.
maxlength in the caller is 0).

The patch also changes the same readfile() function in initdb.c. I
assume it's not a practical problem there, but it should be fixed.

Thanks to Corry Haines (chaines at truviso dot com) for reporting the
problem.

Regards,
    Jeff Davis

Attachment

pgsql-bugs by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: BUG #5028: CASE returns ELSE value always when type is "char"
Next
From: Jeff Davis
Date:
Subject: Re: BUG #5028: CASE returns ELSE value always when type is "char"