Re: clang's static checker report. - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: clang's static checker report.
Date
Msg-id 1251642399.22097.0.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: clang's static checker report.  (Greg Stark <gsstark@mit.edu>)
Responses Re: clang's static checker report.  (Greg Stark <gsstark@mit.edu>)
List pgsql-hackers
On lör, 2009-08-29 at 17:35 +0100, Greg Stark wrote:
> We still have things like this showing "division by zero":
> 
> Assert(activeTapes > 0);
> 1913        slotsPerTape = (state->memtupsize - state->mergefirstfree) / activeTapes;
> 
> 
> It looks like if you marked ExceptionalCondition() as never returning
> then it should hide this.

Well, if you can disable the assertion, then there is still a possible
bug here, no?



pgsql-hackers by date:

Previous
From: Grzegorz Jaskiewicz
Date:
Subject: Re: clang's static checker report.
Next
From: Greg Stark
Date:
Subject: Re: clang's static checker report.