Re: The two "XML Fixes" patches still in need of review - Mailing list pgsql-hackers

From Tom Lane
Subject Re: The two "XML Fixes" patches still in need of review
Date
Msg-id 12427.1553375114@sss.pgh.pa.us
Whole thread Raw
In response to The two "XML Fixes" patches still in need of review  (Chapman Flack <chap@anastigmatix.net>)
Responses Re: The two "XML Fixes" patches still in need of review
List pgsql-hackers
Chapman Flack <chap@anastigmatix.net> writes:
> Alvaro has committed two of the patches in this CF entry[1], but the
> remaining two have yet to attract review.
> This message contains only those two, just as before[2] except rebased
> over Alvaro's commits of the others.

Just to update this thread --- per the other thread at
https://postgr.es/m/CAN-V+g-6JqUQEQZ55Q3toXEN6d5Ez5uvzL4VR+8KtvJKj31taw@mail.gmail.com
I've now pushed a somewhat-adjusted version of the XML-content fix
patch.  The documentation patch needs some small rebasing to apply
after that one instead of before it.

I'm not going to touch the documentation patch myself; I don't know
enough about XML to review it competently.  I do have a small suggestion
though, which is that the large "Limits and Compatibility" section
you added doesn't really seem to me to belong where you put it.
Perhaps it'd make sense under the XML section in datatype.sgml,
but I think I might lean to making it a new section in Appendix D
(SQL Conformance).

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fix XML handling with DOCTYPE
Next
From: Chapman Flack
Date:
Subject: Re: Fix XML handling with DOCTYPE