Re: pgsql: Remove inappropriate memory context switch in - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove inappropriate memory context switch in
Date
Msg-id 12421.1228080543@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove inappropriate memory context switch in  ("Neil Conway" <neilc@samurai.com>)
List pgsql-committers
"Neil Conway" <neilc@samurai.com> writes:
> On Sun, Nov 30, 2008 at 1:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Well, dblink is simply calling SRF_RETURN_DONE() when the current
> context is the multi-call memory context.

So I see.

> We could outlaw that
> practice, but that risks breaking out-of-tree SRFs that do something
> similar.

No, they're already broken; this is just making the breakage more
obvious.  It is not kosher for a SQL-callable function to return with
a different current context than it was called in.

            regards, tom lane

pgsql-committers by date:

Previous
From: "Neil Conway"
Date:
Subject: Re: pgsql: Remove inappropriate memory context switch in
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Remove inappropriate memory context switch in