Re: compile warning in CVS HEAD - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compile warning in CVS HEAD
Date
Msg-id 12394.1079644394@sss.pgh.pa.us
Whole thread Raw
In response to Re: compile warning in CVS HEAD  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> *sigh*

> my local (linux) man for gettimeofday says this:

>        struct timeval {
>                time_t         tv_sec;        /* seconds */
>                suseconds_t    tv_usec;  /* microseconds */
>        };

Yeah, but mine (HPUX) says that tv_sec is "unsigned long".  I suspect
that on Darwin the types disagree as to signedness.

> We could do what you say, or could we just cast it?

If they really were different types (as in different widths) then
casting the pointer would be a highly Wrong Thing.  I think copying
to a local is safer, even if it does waste a cycle or two.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Kurt Roeckx
Date:
Subject: Re: fsync method checking
Next
From: Larry Rosenman
Date:
Subject: UnixWare/CVS Tip/initdb.c needs to use threads flags...