Re: [HACKERS] Concurrent VACUUM: first results - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Concurrent VACUUM: first results
Date
Msg-id 12358.943510641@sss.pgh.pa.us
Whole thread Raw
In response to RE: [HACKERS] Concurrent VACUUM: first results  ("Hiroshi Inoue" <Inoue@tpf.co.jp>)
Responses Re: [HACKERS] Concurrent VACUUM: first results  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
"Hiroshi Inoue" <Inoue@tpf.co.jp> writes:
> CommitTransactionCommand() is executed at the end of vc_getrels()
> and vc_delhilowstats() is executed without StartTransactionCommand().

Oooh, good eye!  I wonder how long that bug's been there?

I'm still inclined to remove that call to vc_delhilowstats, because it
seems like a global delete of statistics can't help but be a problem.
But if we keep it, you're dead right: it has to be inside a transaction.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Hiroshi Inoue"
Date:
Subject: RE: [HACKERS] Concurrent VACUUM: first results
Next
From: Grzegorz Przeździecki
Date:
Subject: Vacuum