Re: RFC: Additional Directory for Extensions - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: RFC: Additional Directory for Extensions
Date
Msg-id 12312928-5516-49b8-81c1-a7b56fd01bc8@dunslane.net
Whole thread Raw
In response to Re: RFC: Additional Directory for Extensions  (Matheus Alcantara <matheusssilv97@gmail.com>)
Responses Re: RFC: Additional Directory for Extensions
List pgsql-hackers
On 2025-02-24 Mo 8:33 AM, Matheus Alcantara wrote:
> Hi,
>
> On Thu, Dec 5, 2024 at 8:07 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> This patch is now complete enough for testing, I think.  As I mentioned
>> earlier, I haven't updated pg_available_extensions() etc. to support the
>> path, but that shouldn't prevent some testing.
> To help with this patch I'm attaching a new version with the remaining TODOs
> fixed and also with a new TAP test.
>
> Thoughts?
>


I think your additions generally look good. We should be able to 
simplify this:


+    system_dir = psprintf("%s/extension", sharepath);
+    ecp = system_dir;
+
+    if (strlen(Extension_control_path) == 0)
+    {
+        paths = lappend(paths, ecp);
+    }


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Small memory fixes for pg_createsubcriber
Next
From: "Daniel Verite"
Date:
Subject: Re: pgbench client-side performance issue on large scripts