Re: Array initialisation notation in syscache.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Array initialisation notation in syscache.c
Date
Msg-id 1228988.1671577542@sss.pgh.pa.us
Whole thread Raw
In response to Array initialisation notation in syscache.c  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Array initialisation notation in syscache.c  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> Do you think this is better?

I'm not at all on board with adding runtime overhead to
save maintaining the nkeys fields.

Getting rid of the useless trailing zeroes in the key[] arrays
is clearly a win, though.

I'm kind of neutral on using "[N] = " as a substitute for
ordering the entries correctly.  While that does remove
one failure mode, it seems like it adds another (ie
failure to provide an entry at all would be masked).

            regards, tom lane



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: meson files copyright
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: [PATCH] Add function to_oct