Re: Do we want a xmalloc or similar function in the Backend? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Do we want a xmalloc or similar function in the Backend?
Date
Msg-id 12259.1340116736@sss.pgh.pa.us
Whole thread Raw
In response to Do we want a xmalloc or similar function in the Backend?  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Do we want a xmalloc or similar function in the Backend?  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> There are 70+ calls of malloc in the backend in the form of

> type* foo = malloc(sizeof(...));
> if(!foo)
>    elog(ERROR, "could not allocate memory");

> which is a bit annoying to write at times. Would somebody argue against 
> introducing a function that does the above named xmalloc() or malloc_or_die()?

99% of the time, you should be using palloc if that's the behavior you
want.  I think most of the malloc calls are in places where we want a
bit more control over the error response.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node
Next
From: Peter Geoghegan
Date:
Subject: Re: sortsupport for text