Re: Better help output for pgbench -I init_steps - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Better help output for pgbench -I init_steps
Date
Msg-id 1223a409-8826-0bf1-1cc4-ddb79cefc0e8@eisentraut.org
Whole thread Raw
In response to Re: Better help output for pgbench -I init_steps  (Tristen Raab <tristen.raab@highgo.ca>)
List pgsql-hackers
On 22.09.23 22:01, Tristen Raab wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  not tested
> Implements feature:       tested, passed
> Spec compliant:           not tested
> Documentation:            not tested
> 
> Hello,
> 
> I've reviewed all 4 of your patches, each one applies and builds correctly.
> 
>> I think I prefer variant 2.  Currently, we only have 8 steps, so it might
>> be overkill to separate them out into a different option.
> 
> +1 to this from Peter. Variant 2 is nicely formatted with lots of information which I feel better solves the problem
thispatch is trying to address.
 

Committed variant 2.  I just changed the initial capitalization of the 
sentences to be more consistent with the surrounding text.




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Is this a problem in GenericXLogFinish()?
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] pgrowlocks: Make mode names consistent with docs