Re: Check for failed memory allocations in libpq - Mailing list pgsql-patches

From Tom Lane
Subject Re: Check for failed memory allocations in libpq
Date
Msg-id 1206.1059660325@sss.pgh.pa.us
Whole thread Raw
In response to Check for failed memory allocations in libpq  (Dave Allen <daveallen@acm.org>)
Responses Re: Check for failed memory allocations in libpq  (Dave Allen <daveallen@acm.org>)
List pgsql-patches
Dave Allen <daveallen@acm.org> writes:
> Attached is a patch (against 7.3.4) to check the return values of some
> calls (malloc, realloc, etc.) for failed memory allocations in libpq.

You sure you aren't just trading one misbehavior for another?  The
change in PQmakeEmptyPGresult, for example, just moves the core dump
somewhere else, unless you find reasonable fallbacks for *all* its
callers (including applications you don't have the source code for,
but in any case including every one of the calls in libpq).

            regards, tom lane

pgsql-patches by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: [Fwd: Re: ruleutils with pretty-print option]
Next
From: Tom Lane
Date:
Subject: Re: Proof-of-concept for initdb-time shared_buffers selection