Re: Add A Glossary - Mailing list pgsql-hackers

From Jürgen Purtz
Subject Re: Add A Glossary
Date
Msg-id 11c93b2a-2445-148b-30a9-35fb9eee82d7@purtz.de
Whole thread Raw
In response to Re: Add A Glossary  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Add A Glossary  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 31.03.20 19:58, Justin Pryzby wrote:
> On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
>> Please find some minor suggestions in the attachment. They are based on
>> Corey's last patch 0001-glossary-v4.patch.
>> @@ -220,7 +220,7 @@
>>         Record</glossterm>s to the file system and creates a special
>>         checkpoint record. This process is initiated when predefined
>>         conditions are met, such as a specified amount of time has passed, or
>> -      a certain volume of records have been collected.
>> +      a certain volume of records has been collected.
> I think you're correct in that "volume" is singular.  But I think "collected"
> is the wrong world.  I suggested "written".
>
"collected" is not optimal. I suggest "created". Please avoid "written", 
the WAL records will be written when the Checkpointer is running, not 
before. So:

  "a certain volume of <glossterm>WAL records<glossterm> has been 
collected."


Every thing else is ok for me.

Kind regards, Jürgen



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: recovery_target_action=pause with confusing hint
Next
From: Jürgen Purtz
Date:
Subject: Re: Add A Glossary