On 31.03.20 19:58, Justin Pryzby wrote:
> On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
>> Please find some minor suggestions in the attachment. They are based on
>> Corey's last patch 0001-glossary-v4.patch.
>> @@ -220,7 +220,7 @@
>> Record</glossterm>s to the file system and creates a special
>> checkpoint record. This process is initiated when predefined
>> conditions are met, such as a specified amount of time has passed, or
>> - a certain volume of records have been collected.
>> + a certain volume of records has been collected.
> I think you're correct in that "volume" is singular. But I think "collected"
> is the wrong world. I suggested "written".
>
"collected" is not optimal. I suggest "created". Please avoid "written",
the WAL records will be written when the Checkpointer is running, not
before. So:
"a certain volume of <glossterm>WAL records<glossterm> has been
collected."
Every thing else is ok for me.
Kind regards, Jürgen