Postgres Pro
Downloads
Home   >   mailing lists

RELEASE STOPPER? nonportable int64 constants in pg_crc.c - Mailing list pgsql-hackers

From Zeugswetter Andreas SB
Subject RELEASE STOPPER? nonportable int64 constants in pg_crc.c
Date
Msg-id 11C1E6749A55D411A9670001FA687963368257@sdexcsrv1.f000.d0188.sd.spardat.at
Whole thread Raw
Responses Re: RELEASE STOPPER? nonportable int64 constants in pg_crc.c  (Peter Eisentraut <peter_e@gmx.net>)
Re: RELEASE STOPPER? nonportable int64 constants in pg_crc.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
Recent changes in pg_crc.c (64 bit CRC) introduced non portable constants of the form:

 -c -o pg_crc.o pg_crc.c
      287 |         0x0000000000000000, 0x42F0E1EBA9EA3693,
            ............................a..................
a - 1506-207 (W) Integer constant 0x42F0E1EBA9EA3693 out of range.

I guess this will show up on a lot of non gcc platforms !!!!!
It shows no diffs in the regression tests! From what I understand,
failure would only show up after fast shutdown/crash.

Attached is a patch, but I have no idea how portable that is.

Andreas
Attachment

pgsql-hackers by date:

Previous
From: Marek PUBLICEWICZ
Date:
Subject: Strange results of CURRENT_TIMESTAMP
Next
From: Bruce Momjian
Date:
Subject: Chat starts in 10 minutes