AW: AW: AW: Re: tinterval - operator problems on AIX - Mailing list pgsql-hackers

From Zeugswetter Andreas SB
Subject AW: AW: AW: Re: tinterval - operator problems on AIX
Date
Msg-id 11C1E6749A55D411A9670001FA6879633681BA@sdexcsrv1.f000.d0188.sd.spardat.at
Whole thread Raw
List pgsql-hackers
> > > > Yes, the annoyance is, that localtime works for dates before 1970
> > > > but mktime doesn't. Best would probably be to assume no DST before
> > > > 1970 on AIX and IRIX.
> > >
> > > That seems like a reasonable answer to me, especially since we have
> > > other platforms that behave that way.  How can we do this --- just
> > > test for isdst = -1 after the call, and assume that means failure?
>
> Are you working on this, or can you point me to the parts of the code,
> that would need change ?

Here is a patch that should make AIX and IRIX more happy.
It changes all checks for tm_isdst to (tm_isdst > 0) and fixes
the expected horology file for AIX.

I just now realized, that the new expected file (while still bogous) is more correct
than the old one.
Thanks to Tom for mentioning that the hour should stay the same when subtracting
days from a timestamp.

Please apply.

Andreas


Attachment

pgsql-hackers by date:

Previous
From: Zeugswetter Andreas SB
Date:
Subject: AW: Re: Performance degradation in PostgreSQL 7.1beta3 vs 6.5.3
Next
From: Zeugswetter Andreas SB
Date:
Subject: AW: AW: AW: Re: tinterval - operator problems on AIX