Re: archive_command failures report confusing exit status - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: archive_command failures report confusing exit status
Date
Msg-id 1197414500.4255.1458.camel@ebony.site
Whole thread Raw
In response to Re: archive_command failures report confusing exit status  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: archive_command failures report confusing exit status  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Tue, 2007-12-11 at 23:31 +0100, Peter Eisentraut wrote:
> Simon Riggs wrote:
> > I prefer archive_command = ... for the errdetail though. The commands
> > can be quite long so the extra words don't really add anything, plus
> > they require translation.
> 
> I did like this suggestion, but then I noticed, we don't actually report the 
> setting of the archive_command setting but the actual command that was 
> executed, with the placeholders filled out.  So I think the way I posted it 
> is more correct.

I think you should lose the "The", if nothing else. Most Postgres
messages I recall say "return code = xx" not "The return code ..."

--  Simon Riggs 2ndQuadrant  http://www.2ndQuadrant.com



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: WORM and Read Only Tables (v0.1)
Next
From: Alvaro Herrera
Date:
Subject: Re: archive_command failures report confusing exit status