Re: A patch for xlog.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: A patch for xlog.c
Date
Msg-id 11948.983032866@sss.pgh.pa.us
Whole thread Raw
In response to A patch for xlog.c  (Matthew Kirkwood <matthew@hairy.beasts.org>)
Responses Re: A patch for xlog.c
List pgsql-patches
Matthew Kirkwood <matthew@hairy.beasts.org> writes:
> Here is a patch against 7.1beta5 to use mmap(), and thus a
> single write, to initialise xlogs.  It may well improve
> performance of this on platforms/filesystems which write
> metadata synchronously.

Have you *demonstrated* any actual performance improvement from this?
How much?  On what platforms?

I don't believe in adding unportable alternative implementations without
pretty darn compelling reasons ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Matthew Kirkwood
Date:
Subject: Small misc tidyup patch
Next
From: Matthew Kirkwood
Date:
Subject: Re: A patch for xlog.c