Re: pg_read_file() with virtual files returns empty string - Mailing list pgsql-hackers

Justin Pryzby <pryzby@telsasoft.com> writes:
> But I noticed that cfbot is now populating with failures like:

> genfile.c: In function ‘read_binary_file’:
> genfile.c:192:5: error: ignoring return value of ‘fread’, declared with attribute warn_unused_result
[-Werror=unused-result]
>      fread(rbuf, 1, 1, file);
>      ^

Yeah, some of the pickier buildfarm members (eg spurfowl) are showing
that as a warning, too.  Maybe make it like

                if (fread(rbuf, 1, 1, file) != 0 || !feof(file))
                    ereport(ERROR,

Probably the feof test is redundant this way, but I'd be inclined to
leave it in anyhow.

            regards, tom lane