Re: pgindent vs dtrace on macos - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent vs dtrace on macos
Date
Msg-id 1177223.1600784320@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent vs dtrace on macos  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pgindent vs dtrace on macos  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 21 Sep 2020, at 20:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Here's a proposed patch to fix it that way.

> +1 on this patch.  Do you think it's worth adding a note about this in the
> documentation to save the next one staring at this a few minutes?  Something
> along the lines of:

> +If an exported function shares a name with a typedef, the header file with the
> +prototype can get incorrect spacing for the function.

AFAIK, a function name that's the same as a typedef name will get
misformatted whether it's exported or not; pgindent doesn't really
know the difference.  But yeah, we could add something about this.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Asynchronous Append on postgres_fdw nodes.
Next
From: Michael Banck
Date:
Subject: Re: [patch] Fix checksum verification in base backups for zero page headers