Re: Getting rid of warnings - Mailing list pgsql-patches

From Neil Conway
Subject Re: Getting rid of warnings
Date
Msg-id 1169742486.5447.29.camel@localhost.localdomain
Whole thread Raw
In response to Re: Getting rid of warnings  (Magnus Hagander <magnus@hagander.net>)
List pgsql-patches
On Thu, 2007-01-25 at 17:11 +0100, Magnus Hagander wrote:
> The header had:
> isort(int4 *a, const int len)
> and the code had
> isort(int4 *a, int len)

ISTM that the "const" keyword to an "int" function argument is
pointless, so the right fix is to remove the "const" from the
declaration in the header.

> Where does the ** part come in there? It's not even a pointer!

I believe Tom was just referencing that as an example of a
less-than-perfect compiler warning from VC++.

-Neil



pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Getting rid of warnings
Next
From: Tom Lane
Date:
Subject: Re: Getting rid of warnings