Re: Getting rid of warnings - Mailing list pgsql-patches

From Tom Lane
Subject Re: Getting rid of warnings
Date
Msg-id 20344.1169742830@sss.pgh.pa.us
Whole thread Raw
In response to Re: Getting rid of warnings  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Getting rid of warnings
List pgsql-patches
Magnus Hagander <magnus@hagander.net> writes:
> Not sure I understand.
> The header had:
> isort(int4 *a, const int len)
> and the code had
> isort(int4 *a, int len)

Oh, I see.  Yeah, that's inconsistent, though my thought would be to
remove the (rather useless) const decoration in the header.  I believe
this coding is actually legal per C99, though, precisely because the
version in the header is only decoration --- callers of the function
do not care whether it thinks the parameter value is immutable inside
itself.  The one at the function definition site is what counts ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: Getting rid of warnings
Next
From: Neil Conway
Date:
Subject: Re: guid/uuid datatype