Re: postgres_fdw: batch inserts vs. before row triggers - Mailing list pgsql-hackers

From Tom Lane
Subject Re: postgres_fdw: batch inserts vs. before row triggers
Date
Msg-id 115833.1669475475@sss.pgh.pa.us
Whole thread Raw
In response to Re: postgres_fdw: batch inserts vs. before row triggers  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: postgres_fdw: batch inserts vs. before row triggers
List pgsql-hackers
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> On Sat, Nov 26, 2022 at 1:57 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Couldn't we add the field to ModifyTableState, instead?

> We could probably do so, but I thought having a global list would be
> more efficient to handle pending buffered inserts than that.

OK, as long as there's a reason for doing it that way, it's OK
by me.  I don't think that adding a field at the end of EState
is an ABI problem.

We have to do something else than add to ResultRelInfo, though.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: MSVC vs Perl
Next
From: Andrew Dunstan
Date:
Subject: Re: CI and test improvements